Fix generic-object false positive#73
Merged
TomasVotruba merged 1 commit intorectorphp:mainfrom Apr 17, 2026
Merged
Conversation
samsonasik
approved these changes
Apr 17, 2026
staabm
commented
Apr 17, 2026
| } | ||
|
|
||
| if ($argType instanceof IntersectionType) { | ||
| if ($argType instanceof IntersectionType || $argType instanceof GenericObjectType) { |
Contributor
Author
There was a problem hiding this comment.
I think this false positives occur, because of the recent changes in ObjectType->equals() in PHPStan and the non-public-api compilant use of the PHPStan Type system ins this package (using instanceof on Type objects).
I don't think its worth our time to make this rule print meaningful results for generic objects. it would involve a very different approach to what this rule is doing today.
therefore I think just skipping generics is the way to go
Member
|
Let's ship it, thank you 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prevent false-positives like